First fix to minimize copying of image data.

chrome/browser/favicon_service.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/favicon_service.h"
 
 #include "chrome/browser/dom_ui/dom_ui_factory.h"
 #include "chrome/browser/history/history.h"
 #include "chrome/browser/history/history_backend.h"
 #include "chrome/browser/profile.h"
@@ skipping 32 matching lines @@
 }
 
 FaviconService::Handle FaviconService::GetFaviconForURL(
     const GURL& page_url,
     CancelableRequestConsumerBase* consumer,
     FaviconDataCallback* callback) {
   GetFaviconRequest* request = new GetFaviconRequest(callback);
   AddRequest(request, consumer);
   FaviconService::Handle handle = request->handle();
   if (page_url.SchemeIs(chrome::kChromeUIScheme)) {
-    std::vector<unsigned char> icon_bytes;
+    // TODO(erg): For now, we're cheating here. DOMUIFactory returns the new
+    // RefCountedMemory superclass, but consumers of favicon information are
+    // still all hardcoded to use RefCountedBytes. For now, just copy the
+    // favicon data in this case because the returned RefCountedMemory class is
+    // the statically allocated memory one; not the vector backed
+    // RefCountedBytes.
     scoped_refptr<RefCountedBytes> icon_data = NULL;
-    bool know_icon = DOMUIFactory::GetFaviconResourceBytes(page_url,
-                                                           &icon_bytes);
-    if (know_icon)
-      icon_data = new RefCountedBytes(icon_bytes);
+    scoped_refptr<RefCountedMemory> static_memory(
+        DOMUIFactory::GetFaviconResourceBytes(page_url));
+    bool know_icon = static_memory.get() != NULL;
+
+    if (know_icon) {
+      std::vector<unsigned char> bytes;
+      bytes.insert(bytes.begin(),
+                   static_memory->front(),
+                   static_memory->front() + static_memory->size());
+      icon_data = RefCountedBytes::TakeVector(&bytes);
+    }
 
     request->ForwardResultAsync(FaviconDataCallback::TupleType(handle,
         know_icon, icon_data, false, GURL()));
   } else {
     HistoryService* hs = profile_->GetHistoryService(Profile::EXPLICIT_ACCESS);
     if (hs)
       hs->GetFaviconForURL(request, page_url);
     else
       ForwardEmptyResultAsync(request);
   }
@@ skipping 18 matching lines @@
                                 const std::vector<unsigned char>& image_data) {
   HistoryService* hs = profile_->GetHistoryService(Profile::EXPLICIT_ACCESS);
   if (hs)
     hs->SetFavicon(page_url, icon_url, image_data);
 }
 
 void FaviconService::ForwardEmptyResultAsync(GetFaviconRequest* request) {
   request->ForwardResultAsync(FaviconDataCallback::TupleType(request->handle(),
         false, NULL, false, GURL()));
 }