chrome/browser/dom_ui/dom_ui_favicon_source.h - Issue 288005: First fix to minimize copying of image data.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/dom_ui/dom_ui_favicon_source.h

Issue 288005: First fix to minimize copying of image data. (Closed)

Patch Set: Modify gyp Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/browser_theme_provider.cc ('K') | « chrome/browser/dom_ui/dom_ui_factory.cc ('k') | chrome/browser/dom_ui/dom_ui_favicon_source.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_DOM_UI_DOM_UI_FAVICON_SOURCE_H_	5 #ifndef CHROME_BROWSER_DOM_UI_DOM_UI_FAVICON_SOURCE_H_

6 #define CHROME_BROWSER_DOM_UI_DOM_UI_FAVICON_SOURCE_H_	6 #define CHROME_BROWSER_DOM_UI_DOM_UI_FAVICON_SOURCE_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 #include "base/basictypes.h"	10 #include "base/basictypes.h"

(...skipping 27 matching lines...) Expand all Loading...
38 scoped_refptr<RefCountedBytes> data,	38 scoped_refptr<RefCountedBytes> data,

39 bool expired,	39 bool expired,

40 GURL url);	40 GURL url);

41	41

42 private:	42 private:

43 Profile* profile_;	43 Profile* profile_;

44 CancelableRequestConsumerT<int, 0> cancelable_consumer_;	44 CancelableRequestConsumerT<int, 0> cancelable_consumer_;

45	45

46 // Raw PNG representation of the favicon to show when the favicon	46 // Raw PNG representation of the favicon to show when the favicon

47 // database doesn't have a favicon for a webpage.	47 // database doesn't have a favicon for a webpage.

48 scoped_refptr<RefCountedBytes> default_favicon_;	48 scoped_refptr<RefCountedMemory> default_favicon_;

49	49

50 DISALLOW_COPY_AND_ASSIGN(DOMUIFavIconSource);	50 DISALLOW_COPY_AND_ASSIGN(DOMUIFavIconSource);

51 };	51 };

52	52

53 #endif // CHROME_BROWSER_DOM_UI_DOM_UI_FAVICON_SOURCE_H_	53 #endif // CHROME_BROWSER_DOM_UI_DOM_UI_FAVICON_SOURCE_H_

OLD	NEW