First fix to minimize copying of image data.

app/resource_bundle.h

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef APP_RESOURCE_BUNDLE_H_
 #define APP_RESOURCE_BUNDLE_H_
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #endif
 
 #include <map>
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/file_path.h"
 #include "base/lock.h"
+#include "base/ref_counted_memory.h"
 #include "base/scoped_ptr.h"
 #include "base/string16.h"
 
 #if defined(USE_BASE_DATA_PACK)
 namespace base {
 class DataPack;
 }
 #endif
 #if defined(USE_X11)
 typedef struct _GdkPixbuf GdkPixbuf;
@@ skipping 53 matching lines @@
   //
   // The bitmap is assumed to exist. This function will log in release, and
   // assert in debug mode if it does not. On failure, this will return a
   // pointer to a shared empty placeholder bitmap so it will be visible what
   // is missing.
   SkBitmap* GetBitmapNamed(int resource_id);
 
   // Loads the raw bytes of an image resource into |bytes|,
   // without doing any processing or interpretation of
   // the resource. Returns whether we successfully read the resource.
-  bool LoadImageResourceBytes(int resource_id,
-                              std::vector<unsigned char>* bytes);
+  RefCountedStaticMemory* LoadImageResourceBytes(int resource_id);
 
   // Loads the raw bytes of a data resource into |bytes|,
   // without doing any processing or interpretation of
   // the resource. Returns whether we successfully read the resource.
-  bool LoadDataResourceBytes(int resource_id,
-                             std::vector<unsigned char>* bytes);
+  RefCountedStaticMemory* LoadDataResourceBytes(int resource_id);
 
   // Return the contents of a file in a string given the resource id.
   // This will copy the data from the resource and return it as a string.
   // TODO(port): deprecate this and replace with GetRawDataResource to avoid
   // needless copying.
   std::string GetDataResource(int resource_id);
 
   // Like GetDataResource(), but avoids copying the resource.  Instead, it
   // returns a StringPiece which points into the actual resource in the image.
   base::StringPiece GetRawDataResource(int resource_id);
@@ skipping 67 matching lines @@
   // external data module.
   void LoadResources(const std::wstring& pref_locale);
 
   // Initialize all the gfx::Font members if they haven't yet been initialized.
   void LoadFontsIfNecessary();
 
   // Returns the full pathname of the locale file to load.  May return an empty
   // string if no locale data files are found.
   FilePath GetLocaleFilePath(const std::wstring& pref_locale);
 
-  // Loads the raw bytes of a resource from |module| into |bytes|,
-  // without doing any processing or interpretation of
-  // the resource. Returns whether we successfully read the resource.
-  static bool LoadResourceBytes(DataHandle module,
-                                int resource_id,
-                                std::vector<unsigned char>* bytes);
+  // Returns a handle to bytes from the resource |module|, without doing any
+  // processing or interpretation of the resource. Returns whether we
+  // successfully read the resource.  Caller does not own the data returned
+  // through this method and must not modify the data pointed to by |bytes|.
+  static RefCountedStaticMemory* LoadResourceBytes(DataHandle module,
+                                                   int resource_id);
 
   // Creates and returns a new SkBitmap given the data file to look in and the
   // resource id.  It's up to the caller to free the returned bitmap when
   // done.
   static SkBitmap* LoadBitmap(DataHandle dll_inst, int resource_id);
 
   // Class level lock.  Used to protect internal data structures that may be
   // accessed from other threads (e.g., skia_images_).
   Lock lock_;
 
@@ skipping 18 matching lines @@
   scoped_ptr<gfx::Font> medium_bold_font_;
   scoped_ptr<gfx::Font> large_font_;
   scoped_ptr<gfx::Font> web_font_;
 
   static ResourceBundle* g_shared_instance_;
 
   DISALLOW_EVIL_CONSTRUCTORS(ResourceBundle);
 };
 
 #endif  // APP_RESOURCE_BUNDLE_H_