First fix to minimize copying of image data.

app/resource_bundle.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "app/resource_bundle.h"
 
 #include "app/gfx/codec/png_codec.h"
 #include "app/gfx/font.h"
 #include "base/logging.h"
 #include "base/string_piece.h"
@@ skipping 51 matching lines @@
 void ResourceBundle::FreeImages() {
   for (SkImageMap::iterator i = skia_images_.begin();
        i != skia_images_.end(); i++) {
     delete i->second;
   }
   skia_images_.clear();
 }
 
 /* static */
 SkBitmap* ResourceBundle::LoadBitmap(DataHandle data_handle, int resource_id) {
-  std::vector<unsigned char> raw_data, png_data;
-  bool success = false;
+  std::vector<unsigned char> png_data;
 
-  if (!success)
-    success = LoadResourceBytes(data_handle, resource_id, &raw_data);
-  if (!success)
+  scoped_refptr<RefCountedMemory> memory(
+      LoadResourceBytes(data_handle, resource_id));
+  if (!memory)
     return NULL;
 
   // Decode the PNG.
   int image_width;
   int image_height;
-  if (!gfx::PNGCodec::Decode(&raw_data.front(), raw_data.size(),
-                             gfx::PNGCodec::FORMAT_BGRA,
-                             &png_data, &image_width, &image_height)) {
+  if (!gfx::PNGCodec::Decode(
+          memory->front(), memory->size(),
+          gfx::PNGCodec::FORMAT_BGRA,
+          &png_data, &image_width, &image_height)) {
     NOTREACHED() << "Unable to decode image resource " << resource_id;
     return NULL;
   }
 
   return gfx::PNGCodec::CreateSkBitmapFromBGRAFormat(png_data,
                                                      image_width,
                                                      image_height);
 }
 
 std::string ResourceBundle::GetDataResource(int resource_id) {
   return GetRawDataResource(resource_id).as_string();
 }
 
-bool ResourceBundle::LoadImageResourceBytes(int resource_id,
-                                            std::vector<unsigned char>* bytes) {
-  return LoadResourceBytes(theme_data_, resource_id, bytes);
+RefCountedStaticMemory* ResourceBundle::LoadImageResourceBytes(
+    int resource_id) {
+  return LoadResourceBytes(theme_data_, resource_id);
 }
 
-bool ResourceBundle::LoadDataResourceBytes(int resource_id,
-                                           std::vector<unsigned char>* bytes) {
-  return LoadResourceBytes(resources_data_, resource_id, bytes);
+RefCountedStaticMemory* ResourceBundle::LoadDataResourceBytes(
+    int resource_id) {
+  return LoadResourceBytes(resources_data_, resource_id);
 }
 
 SkBitmap* ResourceBundle::GetBitmapNamed(int resource_id) {
   // Check to see if we already have the Skia image in the cache.
   {
     AutoLock lock_scope(lock_);
     SkImageMap::const_iterator found = skia_images_.find(resource_id);
     if (found != skia_images_.end())
       return found->second;
   }
@@ skipping 76 matching lines @@
     case MediumFont:
       return *medium_font_;
     case MediumBoldFont:
       return *medium_bold_font_;
     case LargeFont:
       return *large_font_;
     default:
       return *base_font_;
   }
 }