Issue 2880008: Updated cache-invalidation library to @30.

Issue 2880008: Updated cache-invalidation library to @30. (Closed)

Created:
10 years, 5 months ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
ncarter (slow), ghc

CC:
chromium-reviews, ben+cc_chromium.org, Raghu Simha, idana, Paweł Hajdan Jr., tim (not reviewing)

Visibility:
Public.

Description

Updated cache-invalidation library to @30. BUG=34647 TEST=sync_listen_notifications Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51330 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51477

Patch Set 1 #

Patch Set 2 : Fixed windows compile errors #

Patch Set 3 : use @30 #

Patch Set 4 : Fixed compile error #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -2 lines)			Patch
M	DEPS	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/notifier/registration_manager_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/cacheinvalidation/cacheinvalidation.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	third_party/cacheinvalidation/overrides/google/cacheinvalidation/random.h	View		1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

ncarter (slow)

LGTM. On Wed, Jun 30, 2010 at 4:24 PM, <akalin@chromium.org> wrote: > nick, ping! > ...

10 years, 5 months ago (2010-07-01 00:19:09 UTC) #4

akalin

Updated to @26 to fix Windows compile errors, had to add random.h override. On 2010/07/01 ...

10 years, 5 months ago (2010-07-01 22:52:15 UTC) #5

ncarter (slow)

LGTM On Thu, Jul 1, 2010 at 3:52 PM, <akalin@chromium.org> wrote: > Updated to @26 ...

10 years, 5 months ago (2010-07-01 22:55:54 UTC) #6

akalin

Sorry, @30 is the magic number. Checking in as soon as trybots pass. On 2010/07/01 ...

10 years, 5 months ago (2010-07-01 23:22:07 UTC) #7

ncarter (slow)

Rubber stamp #3. LGTM On Thu, Jul 1, 2010 at 4:22 PM, <akalin@chromium.org> wrote: > ...

10 years, 5 months ago (2010-07-01 23:25:03 UTC) #8

akalin

One more rubber stamp, por favor! On 2010/07/01 23:25:03, ncarter wrote: > Rubber stamp #3. ...

10 years, 5 months ago (2010-07-01 23:55:16 UTC) #9

ncarter (slow)

10 years, 5 months ago (2010-07-02 00:22:12 UTC) #10

LGTM

On 2010/07/01 23:55:16, akalin wrote:
> One more rubber stamp, por favor!
> 
> On 2010/07/01 23:25:03, ncarter wrote:
> > Rubber stamp #3.  LGTM
> > 
> > On Thu, Jul 1, 2010 at 4:22 PM, <mailto:akalin@chromium.org> wrote:
> > 
> > > Sorry, @30 is the magic number.
> > >
> > > Checking in as soon as trybots pass.
> > >
> > > On 2010/07/01 22:55:54, ncarter wrote:
> > >
> > >> LGTM
> > >>
> > >
> > >  On Thu, Jul 1, 2010 at 3:52 PM, <mailto:akalin@chromium.org> wrote:
> > >>
> > >
> > >  > Updated to @26 to fix Windows compile errors, had to add random.h
> > >> override.
> > >> >
> > >> > On 2010/07/01 00:19:09, ncarter wrote:
> > >> >
> > >> >> LGTM.
> > >> >>
> > >> >
> > >> >  On Wed, Jun 30, 2010 at 4:24 PM, <mailto:akalin@chromium.org> wrote:
> > >> >>
> > >> >
> > >> >  > nick, ping!
> > >> >> >
> > >> >> >
> > >> >> > On 2010/06/30 21:26:34, ghc wrote:
> > >> >> >
> > >> >> >> LGTM
> > >> >> >>
> > >> >> >
> > >> >> >
> > >> >> >
> > >> >> > http://codereview.chromium.org/2880008/show
> > >> >> >
> > >> >>
> > >> >
> > >> >
> > >> >
> > >> >
> > >> > http://codereview.chromium.org/2880008/show
> > >> >
> > >>
> > >
> > >
> > >
> > >
> > > http://codereview.chromium.org/2880008/show
> > >
> >

Expand Messages | Collapse Messages