Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Issue 2880005: cros_workon: modify to be less verbose (Closed)

Created:
10 years, 5 months ago by Mandeep Singh Baines
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git@chromiumos-git/crosutils.git
Visibility:
Public.

Description

cros_workon: modify to be less verbose We need to be able to use "cros_workon list" in pipelines. Also, would be nice if the other commands were less verbose. Ideally, they should die and return a non-zero value. Also cleaned up the logic in some of the functions. This fixed a couple of bugs: 1) "cros-workon list" would fail if KEYWORDS_FILE didn't exist 2) "cros-workon start" would fail if KEYWORDS_DIR didn't exit Change-Id: I76c87f0e36b72c12e8ae937cbadca6cf21a34bad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -30 lines) Patch
M cros_workon View 3 chunks +7 lines, -30 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mandeep Singh Baines
10 years, 5 months ago (2010-06-30 04:40:24 UTC) #1
Nick Sanders
10 years, 5 months ago (2010-06-30 06:06:29 UTC) #2
lgtm

might be nice in a future revision to auto complete packages or check for
package existence

Powered by Google App Engine
This is Rietveld 408576698