Issue 2879003: Run appcache layout tests in chrome using the ui test harness. ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2879003: Run appcache layout tests in chrome using the ui test harness. ... (Closed)

Created:
10 years, 6 months ago by michaeln

Modified:
9 years, 7 months ago

Reviewers:
jianli

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Run appcache layout tests in chrome using the ui test harness. BUG=39365 TEST=yes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51059

Created: 10 years, 5 months ago

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -4 lines)
M	DEPS	View	1 chunk	+3 lines, -0 lines	0 comments
A	chrome/browser/appcache/appcache_ui_test.cc	View	1 chunk	+75 lines, -0 lines	0 comments
M	chrome/chrome_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments
M	chrome/test/data/layout_tests/layout_test_controller.html	View	1 chunk	+1 line, -1 line	0 comments
M	chrome/test/ui/ui_layout_test.cc	View	2 chunks	+14 lines, -3 lines	0 comments

Total messages: 2 (0 generated)

michaeln

Hi Jian, This change was reverted because some of the existing tests didn't work after ...

10 years, 5 months ago (2010-06-28 19:10:36 UTC) #1

LGTM.