Issue 2878081: Clean up inclusion of <map>, <set>, <vector> in chrome/browser/*.h.

Issue 2878081: Clean up inclusion of <map>, <set>, <vector> in chrome/browser/*.h. (Closed)

Created:
10 years, 4 months ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
Lei Zhang, Elliot Glaysher

CC:
chromium-reviews, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

Clean up inclusion of <map>, <set>, <vector> in chrome/browser/*.h. BUG=none TEST=builds Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55135

Patch Set 1 #

Total comments: 2

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -19 lines)			Patch
M	chrome/browser/blocked_popup_container.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_accessibility_win.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/browsing_data_local_storage_helper.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/bug_report_util.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/fav_icon_helper.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/fav_icon_helper.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/icon_manager.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/io_thread.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/managed_prefs_banner_base.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/mock_browsing_data_appcache_helper.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/mock_browsing_data_database_helper.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/mock_browsing_data_local_storage_helper.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/plugin_service.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/plugin_updater.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/possible_url_model.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/profile_impl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/profile_manager.h	View	1 chunk	+0 lines, -1 line	2 comments	Download
M	chrome/browser/wrench_menu_model.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

LGTM http://codereview.chromium.org/2878081/diff/1/18 File chrome/browser/profile_manager.h (right): http://codereview.chromium.org/2878081/diff/1/18#newcode11 chrome/browser/profile_manager.h:11: #include <string> Are you going to do another ...

10 years, 4 months ago (2010-08-05 19:39:08 UTC) #2

viettrungluu

10 years, 4 months ago (2010-08-05 21:45:15 UTC) #3

Thanks.

http://codereview.chromium.org/2878081/diff/1/18
File chrome/browser/profile_manager.h (right):

http://codereview.chromium.org/2878081/diff/1/18#newcode11
chrome/browser/profile_manager.h:11: #include <string>
On 2010/08/05 19:39:08, Lei Zhang wrote:
> Are you going to do another round and remove string?

Yeah, I guess I will.

Expand Messages | Collapse Messages