Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: bin/cros_overlay_list

Issue 2878077: Add checks that the board and variant names don't contain underscores. (Closed) Base URL: ssh://git@chromiumos-git/crosutils.git
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bin/cros_overlay_list
diff --git a/bin/cros_overlay_list b/bin/cros_overlay_list
index 5aeb2d49cea3e4865dc35a91f714d23cdf327e6d..1d768663e922cab082796f51466a27da862ad618 100755
--- a/bin/cros_overlay_list
+++ b/bin/cros_overlay_list
@@ -30,6 +30,16 @@ if [ -z "$FLAGS_board" ] ; then
exit 1
fi
+if [[ "$FLAGS_board" =~ "_" ]] ; then
+ error "--board name must not contain an underscore (_)."
+ exit 1
+fi
+
+if [[ "$FLAGS_variant" =~ "_" ]] ; then
+ error "--variant name must not contain an underscore (_)."
+ exit 1
+fi
+
#
# Check for chromeos-overlay.
#
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698