Issue 2878072: Merge 53736 - Make theme change notifications auto-propagate through the view...

Issue 2878072: Merge 53736 - Make theme change notifications auto-propagate through the view... (Closed)

Created:
10 years, 4 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, nkostylev+cc_chromium.org, ben+cc_chromium.org, Erik does not do reviews, Paul Godavari, Aaron Boodman, pam+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/472/src/

Visibility:
Public.

Description

Merge 53736 - Make theme change notifications auto-propagate through the view hierarchy, instead of forcing subclasses to manually call their superclass implementation. This fixes some problems where not all views would get notified of a theme change. Make naming for theme and locale changes consistent and clear. BUG=50107 TEST=none Review URL: http://codereview.chromium.org/2878055 TBR=pkasting@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54663

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -60 lines)			Patch
M	chrome/browser/chromeos/login/background_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/background_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/eula_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/eula_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/network_selection_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/network_selection_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/new_user_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/new_user_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/user_image_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/user_image_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/status/language_menu_button.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/status/language_menu_button.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/views/bookmark_bar_instructions_view.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/views/bookmark_bar_instructions_view.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/views/bookmark_bar_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/bookmark_bar_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/constrained_window_win.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/views/download_shelf_view.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/views/download_shelf_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/extensions/extension_shelf.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/extensions/extension_shelf.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/find_bar_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/find_bar_view.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/views/tabs/base_tab.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/tabs/base_tab.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/views/tabs/tab.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/tabs/tab.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/views/tabs/tab_strip.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/tabs/tab_strip.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/toolbar_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/toolbar_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	views/view.h	View	2 chunks	+13 lines, -9 lines	0 comments	Download
M	views/view.cc	View	1 chunk	+6 lines, -5 lines	0 comments	Download
M	views/widget/root_view.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	views/widget/root_view.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	views/window/non_client_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages