Add keyboard shortcuts for next/previous pane on Chrome OS, and fix...

Add keyboard shortcuts for next/previous pane on Chrome OS, and fix
alphabetization. Note that the F1 key is the "Back" key on Chrome OS,
and F2 is "Forwards".

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53827

[Daniel Erat, 2010-07-27 16:13:45]

http://codereview.chromium.org/2878059/diff/1/2
File chrome/browser/views/accelerator_table_gtk.cc (right):

http://codereview.chromium.org/2878059/diff/1/2#newcode53
chrome/browser/views/accelerator_table_gtk.cc:53: #if defined(OS_CHROMEOS)
If you change the order in this file, please also update the order in
../../app/chrome_dll.rc (see the comment at the top).

http://codereview.chromium.org/2878059/diff/1/2#newcode55
chrome/browser/views/accelerator_table_gtk.cc:55: #else
Mind avoiding #else here, and just using "#if defined" around each block
instead?  I think that the else-es make it harder to move entries around later
if needed, and I'm worried against accidental mistakes being made in the future.

[dmazzoni, 2010-07-27 16:23:28]

No problem, done.

- Dominic

On Tue, Jul 27, 2010 at 9:13 AM, <derat@chromium.org> wrote:

>
> http://codereview.chromium.org/2878059/diff/1/2
> File chrome/browser/views/accelerator_table_gtk.cc (right):
>
> http://codereview.chromium.org/2878059/diff/1/2#newcode53
> chrome/browser/views/accelerator_table_gtk.cc:53: #if
> defined(OS_CHROMEOS)
> If you change the order in this file, please also update the order in
> ../../app/chrome_dll.rc (see the comment at the top).
>
> http://codereview.chromium.org/2878059/diff/1/2#newcode55
> chrome/browser/views/accelerator_table_gtk.cc:55: #else
> Mind avoiding #else here, and just using "#if defined" around each block
> instead?  I think that the else-es make it harder to move entries around
> later if needed, and I'm worried against accidental mistakes being made
> in the future.
>
>
> http://codereview.chromium.org/2878059/show
>

[Daniel Erat, 2010-07-27 16:34:57]

Thanks!  LGTM