Issue 2878057: Fix some bugs in Function.prototype.bind implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2878057: Fix some bugs in Function.prototype.bind implementation. (Closed)

Created:
10 years, 5 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
William Hesse, Rico

CC:
v8-dev

Visibility:
Public.

Description

Fix some bugs in Function.prototype.bind implementation. Correctly handle not passing thisArg. Fixes to NewObjectFromBound to use correct argument count, not leak memory, and handle constructors that throw exceptions.

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
	M	src/runtime.cc	View		1 chunk	+10 lines, -4 lines	0 comments	Download
	M	src/v8natives.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages