Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1514)

Unified Diff: chrome/browser/cocoa/bookmark_button.mm

Issue 2878037: [Mac]Implement ViewID support. (third approach) (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Update according to review feedback. Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/bookmark_bar_view.mm ('k') | chrome/browser/cocoa/download_shelf_view.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/bookmark_button.mm
diff --git a/chrome/browser/cocoa/bookmark_button.mm b/chrome/browser/cocoa/bookmark_button.mm
index 00a6b775c82cfe0be9d7406e132acf2802a71b6c..bfacc8fec333f7cb1fb9c291631a7549234bdc4a 100644
--- a/chrome/browser/cocoa/bookmark_button.mm
+++ b/chrome/browser/cocoa/bookmark_button.mm
@@ -8,6 +8,7 @@
#include "chrome/browser/bookmarks/bookmark_model.h"
#import "chrome/browser/cocoa/bookmark_button_cell.h"
#import "chrome/browser/cocoa/browser_window_controller.h"
+#import "chrome/browser/cocoa/view_id_util.h"
// The opacity of the bookmark button drag image.
static const CGFloat kDragImageOpacity = 0.7;
@@ -24,6 +25,20 @@ static const CGFloat kDragImageOpacity = 0.7;
@synthesize delegate = delegate_;
+- (id)initWithFrame:(NSRect)frameRect {
+ // BookmarkButton's ViewID may be changed to VIEW_ID_OTHER_BOOKMARKS in
+ // BookmarkBarController, so we can't just override -viewID method to return
+ // it.
+ if ((self = [super initWithFrame:frameRect]))
+ view_id_util::SetID(self, VIEW_ID_BOOKMARK_BAR_ELEMENT);
+ return self;
+}
+
+- (void)dealloc {
+ view_id_util::UnsetID(self);
+ [super dealloc];
+}
+
- (const BookmarkNode*)bookmarkNode {
return [[self cell] bookmarkNode];
}
« no previous file with comments | « chrome/browser/cocoa/bookmark_bar_view.mm ('k') | chrome/browser/cocoa/download_shelf_view.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698