[Mac]Implement ViewID support. (third approach)

chrome/browser/cocoa/tab_contents_controller.mm

-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/cocoa/tab_contents_controller.h"
 
 #include "base/mac_util.h"
 #include "base/sys_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/bookmarks/bookmark_model.h"
+#import "chrome/browser/cocoa/view_id_util.h"
 #include "chrome/browser/pref_service.h"
 #include "chrome/browser/renderer_host/render_view_host.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/common/pref_names.h"
 
 // Default offset of the contents splitter in pixels.
 static const int kDefaultContentsSplitOffset = 400;
 
 // Never make the web part of the tab contents smaller than this (needed if the
 // window is only a few pixels high).
@@ skipping 64 matching lines @@
 
     // Load the default split offset.  If we are already showing devtools, we
     // will replace the default with the current devtools height.
     CGFloat splitOffset = g_browser_process->local_state()->GetInteger(
         prefs::kDevToolsSplitLocation);
     if (splitOffset == -1) {
       // Initial load, set to default value.
       splitOffset = kDefaultContentsSplitOffset;
     }
 
+    // |devtoolsView| is a TabContentsViewCocoa object, whose ViewID was
+    // set to VIEW_ID_TAB_CONTAINER initially, so we need to change it to
+    // VIEW_ID_DEV_TOOLS_DOCKED here.
+    NSView* devtoolsView = devToolsContents->GetNativeView();
+    view_id_util::SetID(devtoolsView, VIEW_ID_DEV_TOOLS_DOCKED);
     if ([subviews count] == 1) {
-      [contentsContainer_ addSubview:devToolsContents->GetNativeView()];
+      [contentsContainer_ addSubview:devtoolsView];
     } else {
       DCHECK_EQ([subviews count], 2u);
       [contentsContainer_ replaceSubview:[subviews objectAtIndex:1]
                                     with:devToolsContents->GetNativeView()];
       // If devtools are already visible, keep the current size.
-      splitOffset = NSHeight([devToolsContents->GetNativeView() frame]);
+      splitOffset = NSHeight([devtoolsView frame]);
     }
 
     // Make sure |splitOffset| isn't too large or too small.
     splitOffset = MIN(splitOffset,
                       NSHeight([contentsContainer_ frame]) - kMinWebHeight);
     DCHECK_GE(splitOffset, 0) << "kMinWebHeight needs to be smaller than "
                               << "smallest available tab contents space.";
     splitOffset = MAX(0, splitOffset);
 
     // It seems as if |-setPosition:ofDividerAtIndex:| should do what's needed,
     // but I can't figure out how to use it. Manually resize web and devtools.
-    NSRect devtoolsFrame = [devToolsContents->GetNativeView() frame];
+    NSRect devtoolsFrame = [devtoolsView frame];
     devtoolsFrame.size.height = splitOffset;
-    [devToolsContents->GetNativeView() setFrame:devtoolsFrame];
+    [devtoolsView setFrame:devtoolsFrame];
 
     NSRect webFrame = [[subviews objectAtIndex:0] frame];
     webFrame.size.height = NSHeight([contentsContainer_ frame]) -
                            [self devToolsHeight];
     [[subviews objectAtIndex:0] setFrame:webFrame];
 
     [contentsContainer_ adjustSubviews];
   } else {
     if ([subviews count] > 1) {
       NSView* oldDevToolsContentsView = [subviews objectAtIndex:1];
       // Store split offset when hiding devtools window only.
       int splitOffset = NSHeight([oldDevToolsContentsView frame]);
       g_browser_process->local_state()->SetInteger(
           prefs::kDevToolsSplitLocation, splitOffset);
       [oldDevToolsContentsView removeFromSuperview];
     }
   }
 }
 
 - (CGFloat)devToolsHeight {
   NSArray* subviews = [contentsContainer_ subviews];
   if ([subviews count] < 2)
     return 0;
   return NSHeight([[subviews objectAtIndex:1] frame]) +
          [contentsContainer_ dividerThickness];
 }
 
 @end