Issue 2878022: Add PrintedPage::GetCenteredPageContentRect so Mac and Win can share code.

Issue 2878022: Add PrintedPage::GetCenteredPageContentRect so Mac and Win can share code. (Closed)

Created:
10 years, 5 months ago by hamaji

Modified:
9 years, 5 months ago

Reviewers:
hayato, Yuzo

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Add PrintedPage::GetCenteredPageContentRect so Mac and Win can share code. BUG=47277 TEST=printed_page_unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51626

Patch Set 2 : fix a compile error #

Total comments: 6

Patch Set 5 : remove #include for gtest #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -23 lines)			Patch
M	printing/printed_document_mac.cc	View		1 chunk	+3 lines, -12 lines	0 comments	Download
M	printing/printed_document_win.cc	View		1 chunk	+2 lines, -11 lines	0 comments	Download
M	printing/printed_page.h	View	2 3 4	1 chunk	+5 lines, -0 lines	0 comments	Download
M	printing/printed_page.cc	View		1 chunk	+13 lines, -0 lines	0 comments	Download
A	printing/printed_page_unittest.cc	View	1 2	1 chunk	+67 lines, -0 lines	0 comments	Download
M	printing/printing.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yuzo

http://codereview.chromium.org/2878022/diff/8/2005 File printing/printed_page_unittest.cc (right): http://codereview.chromium.org/2878022/diff/8/2005#newcode15 printing/printed_page_unittest.cc:15: scoped_refptr<PrintedPage> page( Why do we need a scoped_refptr here? ...

10 years, 5 months ago (2010-07-05 03:01:48 UTC) #2

hamaji

Thanks for comments! http://codereview.chromium.org/2878022/diff/8/2005 File printing/printed_page_unittest.cc (right): http://codereview.chromium.org/2878022/diff/8/2005#newcode15 printing/printed_page_unittest.cc:15: scoped_refptr<PrintedPage> page( On 2010/07/05 03:01:48, Yuzo ...

10 years, 5 months ago (2010-07-05 05:05:55 UTC) #3

Yuzo

LGTM http://codereview.chromium.org/2878022/diff/9001/10004 File printing/printed_page.h (right): http://codereview.chromium.org/2878022/diff/9001/10004#newcode13 printing/printed_page.h:13: #include "testing/gtest/include/gtest/gtest_prod.h" We don't need to include this ...

10 years, 5 months ago (2010-07-05 05:18:49 UTC) #4

hamaji

10 years, 5 months ago (2010-07-05 06:23:02 UTC) #5

http://codereview.chromium.org/2878022/diff/9001/10004
File printing/printed_page.h (right):

http://codereview.chromium.org/2878022/diff/9001/10004#newcode13
printing/printed_page.h:13: #include "testing/gtest/include/gtest/gtest_prod.h"
On 2010/07/05 05:18:49, Yuzo wrote:
> We don't need to include this file any more.

Done. Thanks.

Expand Messages | Collapse Messages