Rename the download to its final name only after the download is finished

chrome/browser/download/download_manager.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The DownloadManager object manages the process of downloading, including
 // updates to the history system and providing the information for displaying
 // the downloads view in the Destinations tab. There is one DownloadManager per
 // active profile in Chrome.
 //
 // Download observers:
@@ skipping 39 matching lines @@
 class ResourceDispatcherHost;
 class URLRequestContextGetter;
 class TabContents;
 struct DownloadSaveInfo;
 
 // Browser's download manager: manages all downloads and destination view.
 class DownloadManager : public base::RefCountedThreadSafe<DownloadManager>,
                         public SelectFileDialog::Listener {
   // For testing.
   friend class DownloadManagerTest;
+  friend class MockDownloadManager;
 
  public:
   // A fake download table ID which representas a download that has started,
   // but is not yet in the table.
   static const int kUninitializedHandle;
 
   DownloadManager();
 
   static void RegisterUserPrefs(PrefService* prefs);
 
@@ skipping 241 matching lines @@
   // suggested file path exists.
   void OnPathExistenceAvailable(DownloadCreateInfo* info);
 
   // Called back after a target path for the file to be downloaded to has been
   // determined, either automatically based on the suggested file name, or by
   // the user in a Save As dialog box.
   void ContinueStartDownload(DownloadCreateInfo* info,
                              const FilePath& target_path);
 
   // Update the history service for a particular download.
-  void UpdateHistoryForDownload(DownloadItem* download);
+  // Marked virtual for testing.
+  virtual void UpdateHistoryForDownload(DownloadItem* download);
   void RemoveDownloadFromHistory(DownloadItem* download);
   void RemoveDownloadsFromHistoryBetween(const base::Time remove_begin,
                                          const base::Time remove_before);
 
   // Create an extension based on the file name and mime type.
   static void GenerateExtension(const FilePath& file_name,
                                 const std::string& mime_type,
                                 FilePath::StringType* generated_extension);
 
   // Create a file name based on the response from the server.
@@ skipping 12 matching lines @@
   static void OnPauseDownloadRequest(ResourceDispatcherHost* rdh,
                                      int render_process_id,
                                      int request_id,
                                      bool pause);
 
   // Performs the last steps required when a download has been completed.
   // It is necessary to break down the flow when a download is finished as
   // dangerous downloads are downloaded to temporary files that need to be
   // renamed on the file thread first.
   // Invoked on the UI thread.
-  void ContinueDownloadFinished(DownloadItem* download);
+  // Marked virtual for testing.
+  virtual void ContinueDownloadFinished(DownloadItem* download);
 
   // Renames a finished dangerous download from its temporary file name to its
   // real file name.
   // Invoked on the file thread.
   void ProceedWithFinishedDangerousDownload(int64 download_handle,
                                             const FilePath& path,
                                             const FilePath& original_name);
 
   // Invoked on the UI thread when a dangerous downloaded file has been renamed.
   void DangerousDownloadRenamed(int64 download_handle,
                                 bool success,
                                 const FilePath& new_path,
                                 int new_path_uniquifier);
 
   // Checks whether a file represents a risk if downloaded.
   bool IsDangerous(const FilePath& file_name);
 
   // Updates the app icon about the overall download progress.
-  void UpdateAppIcon();
+  // Marked virtual for testing.
+  virtual void UpdateAppIcon();
 
   // Changes the paths and file name of the specified |download|, propagating
   // the change to the history system.
   void RenameDownload(DownloadItem* download, const FilePath& new_path);
 
   // Inform observers that the model has changed.
   void NotifyModelChanged();
 
   // 'downloads_' is map of all downloads in this profile. The key is the handle
   // returned by the history system, which is unique across sessions. This map
@@ skipping 75 matching lines @@
   // Downloads are expected to have unique handles, so FakeDbHandleGenerator
   // automatically decrement the handle value on every use.
   FakeDbHandleGenerator fake_db_handle_;
 
   scoped_ptr<OtherDownloadManagerObserver> other_download_manager_observer_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadManager);
 };
 
 #endif  // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_MANAGER_H_