Issue 2876045: base: Get rid of the deprecated SysInfo::GetEnvVar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2876045: base: Get rid of the deprecated SysInfo::GetEnvVar. (Closed)

Created:
10 years, 5 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, John Grabowski, ben+cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org, brettw-cc_chromium.org

Base URL:
git://git.chromium.org/chromium.git

Visibility:
Public.

base: Get rid of the deprecated SysInfo::GetEnvVar. Use the new EnvVarGetter::GetEnv instead. BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51829

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -39 lines)			Patch
M	base/sys_info.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	base/sys_info_posix.cc	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	base/sys_info_unittest.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	base/sys_info_win.cc	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/browser_init.cc	View	2 chunks	+6 lines, -3 lines	0 comments	Download
M	courgette/encoded_program.cc	View	3 chunks	+8 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM

Thanks for this series of patches.