Implement indeterminate checkbox for the generic theme....

Implement indeterminate checkbox for the generic theme.

BUG=36321, 48154
TEST=This is a part of test code.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51499

[Roland Steiner, 2010-07-02 04:21:21]

Mostly LGTM, with one nit (typo) and some comments.

http://codereview.chromium.org/2876036/diff/5001/6001
File webkit/tools/test_shell/test_shell_webthemecontrol.cc (right):

http://codereview.chromium.org/2876036/diff/5001/6001#newcode270
webkit/tools/test_shell/test_shell_webthemecontrol.cc:270: case
kIndeterminateCheckeBox_Type:
typo 'Checke'

http://codereview.chromium.org/2876036/diff/5001/6001#newcode273
webkit/tools/test_shell/test_shell_webthemecontrol.cc:273: bg_color_,
fg_color_);
This is just a shortcut for box() + line() (?)

http://codereview.chromium.org/2876036/diff/5001/6002
File webkit/tools/test_shell/test_shell_webthemecontrol.h (right):

http://codereview.chromium.org/2876036/diff/5001/6002#newcode75
webkit/tools/test_shell/test_shell_webthemecontrol.h:75:
kIndeterminateCheckeBox_Type,
typo 'Checke'

http://codereview.chromium.org/2876036/diff/5001/6003
File webkit/tools/test_shell/test_shell_webthemeengine.cc (right):

http://codereview.chromium.org/2876036/diff/5001/6003#newcode116
webkit/tools/test_shell/test_shell_webthemeengine.cc:116: // it's equivalent to
unchecked.
FWIW, I usu. saw indeterminate check boxes most often using 'checked' as
fallback, but I guess either is OK.

http://codereview.chromium.org/2876036/diff/5001/6003#newcode118
webkit/tools/test_shell/test_shell_webthemeengine.cc:118: ctype =
Control::kIndeterminateCheckeBox_Type;
Typo 'Checke'

[tkent, 2010-07-02 04:26:18]

Oops, I fixed the symbol typo.

On 2010/07/02 04:21:21, Roland Steiner wrote:
> http://codereview.chromium.org/2876036/diff/5001/6001#newcode273
> webkit/tools/test_shell/test_shell_webthemecontrol.cc:273: bg_color_,
> fg_color_);
> This is just a shortcut for box() + line() (?)

Right.

[Dirk Pranke, 2010-07-02 18:59:03]

LGTM as well w/ Roland's fixes.