Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: chrome/browser/sync/notifier/server_notifier_thread.cc

Issue 2876014: Fixed app name used for server-issued notifications. (Closed)
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/notifier/server_notifier_thread.cc
diff --git a/chrome/browser/sync/notifier/server_notifier_thread.cc b/chrome/browser/sync/notifier/server_notifier_thread.cc
index 093adb433b1159faa21aac0bd730f50f31937a05..a6377b8f275d66958c848d81f620b85c754a6e9c 100644
--- a/chrome/browser/sync/notifier/server_notifier_thread.cc
+++ b/chrome/browser/sync/notifier/server_notifier_thread.cc
@@ -111,11 +111,11 @@ void ServerNotifierThread::StartInvalidationListener() {
StopInvalidationListener();
chrome_invalidation_client_.reset(new ChromeInvalidationClient());
- // TODO(akalin): If we can figure out a unique per-session key that
- // is preserved by the server, we can use that instead of kAppName.
- // What this buys us is that we then won't receive any notifications
- // that were generated by ourselves.
- const std::string kAppName = "cc_sync_listen_notifications";
+ // TODO(akalin): Make cache_guid() part of the app name. If we do
+ // so and we somehow propagate it up to the server somehow, we can
+ // make it so that we won't receive any notifications that were
+ // generated from our own changes.
+ const std::string kAppName = "server_notifier_thread";
chrome_invalidation_client_->Start(kAppName, this, xmpp_client());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698