Issue 2876011: Do integer mod via sum-of-digits technique. This benefits the date

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2876011: Do integer mod via sum-of-digits technique. This benefits the date (Closed)

Created:
10 years, 6 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Do integer mod via sum-of-digits technique. This benefits the date code. Committed: http://code.google.com/p/v8/source/detail?r=4964

Patch Set 1 #

Total comments: 2

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+355 lines, -23 lines)			Patch
M	src/arm/codegen-arm.h	View	1 chunk	+68 lines, -0 lines	0 comments	Download
M	src/arm/codegen-arm.cc	View	13 chunks	+232 lines, -14 lines	1 comment	Download
M	src/arm/ic-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1 chunk	+9 lines, -4 lines	0 comments	Download
M	src/code-stubs.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	test/mjsunit/mod.js	View	1 chunk	+38 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

10 years, 5 months ago (2010-06-28 07:19:36 UTC) #2

LGTM

http://codereview.chromium.org/2876011/diff/1/2
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/2876011/diff/1/2#newcode6266
src/arm/codegen-arm.cc:6266: void DigitSum(MacroAssembler* masm,
static (times 5)? And why are these functions not just private members of the
IntegerModStub?

http://codereview.chromium.org/2876011/diff/1/8
File test/mjsunit/mod.js (right):

http://codereview.chromium.org/2876011/diff/1/8#newcode31
test/mjsunit/mod.js:31: m = i % j;
This kind of assumes that -((-i) % j) is not handled by the new code. Currently
it isn't, but it might be extended to do that. How about adding a %TestModulus
to runtime.cc which just calls fmod instead?

Expand Messages | Collapse Messages