Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2873074: Add a command line switch to control accelerated 2d canvas (Closed)

Created:
10 years, 5 months ago by jamesr
Modified:
9 years, 6 months ago
CC:
chromium-reviews, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Add a command line switch to control accelerated 2d canvas TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54159

Patch Set 1 #

Patch Set 2 : Serialize the preference over IPC so the renderer can see it #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +3 lines, -0 lines 1 comment Download
M chrome/common/render_messages.h View 2 chunks +2 lines, -0 lines 0 comments Download
M webkit/glue/webpreferences.h View 2 chunks +2 lines, -0 lines 0 comments Download
M webkit/glue/webpreferences.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jamesr
10 years, 5 months ago (2010-07-27 23:57:22 UTC) #1
darin (slow to review)
LGTM
10 years, 5 months ago (2010-07-27 23:58:35 UTC) #2
jamesr
http://codereview.chromium.org/2873074/diff/4001/5002 File chrome/common/chrome_switches.cc (right): http://codereview.chromium.org/2873074/diff/4001/5002#newcode293 chrome/common/chrome_switches.cc:293: const char kEnableClickToPlay[] = "enable-click-to-play"; I don't know why ...
10 years, 4 months ago (2010-07-29 02:19:21 UTC) #3
jamesr
PTAL. Only diff is in render_messages.h (despite what rietvelds diff-between-patches thingy says).
10 years, 4 months ago (2010-07-29 02:25:47 UTC) #4
Stephen White
On 2010/07/29 02:25:47, jamesr wrote: > PTAL. Only diff is in render_messages.h (despite what rietvelds ...
10 years, 4 months ago (2010-07-29 03:04:18 UTC) #5
darin (slow to review)
10 years, 4 months ago (2010-07-29 05:58:26 UTC) #6
LGTM2

Powered by Google App Engine
This is Rietveld 408576698