Enable crash reporting by default with PyAuto on Mac/Linux

chrome/test/pyautolib/pyauto.py

 #!/usr/bin/python
 
 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """PyAuto: Python Interface to Chromium's Automation Proxy.
 
 PyAuto uses swig to expose Automation Proxy interfaces to Python.
 For complete documentation on the functionality available,
@@ skipping 42 matching lines @@
                   os.path.join(chrome_src, 'xcodebuild', 'Release')],
       'win32':  [ os.path.join(chrome_src, 'chrome', 'Debug'),
                   os.path.join(chrome_src, 'chrome', 'Release')],
       'cygwin': [ os.path.join(chrome_src, 'chrome', 'Debug'),
                   os.path.join(chrome_src, 'chrome', 'Release')],
   }
   deps_dirs = [ os.path.join(script_dir, os.pardir,
                              os.pardir, os.pardir, 'third_party'),
                 script_dir,
   ]
-  sys.path += bin_dirs.get(sys.platform, []) + deps_dirs
+  sys.path += map(os.path.normpath, bin_dirs.get(sys.platform, []) + deps_dirs)
 
 _LocateBinDirs()
 
 try:
   import pyautolib
   # Needed so that all additional classes (like: FilePath, GURL) exposed by
   # swig interface get available in this module.
   from pyautolib import *
 except ImportError:
   print >>sys.stderr, "Could not locate built libraries. Did you build?"
@@ skipping 1223 matching lines @@
       if self._HasTestCases('__main__'):    # we are running a test script
         args.append('__main__')   # run the test cases found in it
       else:  # run tests from the test description file
         pyauto_tests_file = os.path.join(self.TestsDir(), self._tests_filename)
         logging.debug("Reading %s", pyauto_tests_file)
         if not os.path.exists(pyauto_tests_file):
           logging.warn("%s missing. Cannot load tests." % pyauto_tests_file)
         else:
           args = self._LoadTestNamesFrom(pyauto_tests_file)
     args = args * self._options.repeat
-    logging.debug("Loading tests from %s", args)
+    logging.debug("Loading %d tests from %s", len(args), args)
     loaded_tests = unittest.defaultTestLoader.loadTestsFromNames(args)
     return loaded_tests
 
   def _LoadTestNamesFrom(self, filename):
     modules= PyUITest.EvalDataFrom(filename)
     platform = sys.platform
     if PyUITest.IsChromeOS():  # check if it's chromeos
       platform = 'chromeos'
     assert platform in self._platform_map, '%s unsupported' % platform
     all_names = modules.get('all', []) + \
@@ skipping 11 matching lines @@
     if excluded:
       logging.debug('Excluded %d test(s): %s' % (len(excluded), excluded))
     return args
 
   def _Run(self):
     """Run the tests."""
     if self._options.wait_for_debugger:
       raw_input('Attach debugger to process %s and hit <enter> ' % os.getpid())
 
     suite_args = [sys.argv[0]]
-    if self._options.chrome_flags:
-      suite_args.append('--extra-chrome-flags=' + self._options.chrome_flags)
+    chrome_flags = self._options.chrome_flags
+    # Enable crash reporter by default on posix. It's already enabled on win.

[John Grabowski, 2010/07/27 23:35:30]

If already enabled by default on windows (in the binary itself?), why not enable
it by default on Mac/Linux in the binary itself?

If enabled by cmd line args, why not put this one where that is?

[Nirnimesh, 2010/07/28 01:14:03]

The win flow is somewhat different, esp after the new first run ui changes.
The choice to enable/disable crash reporting (and user stats) is made at the
installer level, at the time of downloading the installer.

For PyAuto we override the first run UI, which in the old case meant that this
option is disabled by default, but in the new case means that it's enabled by
default. The new first run flow is not available on mac/linux yet.

+    if PyUITest.IsPosix():
+      chrome_flags += ' --enable-crash-reporter'
+    if chrome_flags:
+      suite_args.append('--extra-chrome-flags=%s' % chrome_flags)
     pyauto_suite = PyUITestSuite(suite_args)
     loaded_tests = self._LoadTests(self._args)
     pyauto_suite.addTests(loaded_tests)
     verbosity = 1
     if self._options.verbose:
       verbosity = 2
     result = unittest.TextTestRunner(verbosity=verbosity).run(pyauto_suite)
     del loaded_tests  # Need to destroy test cases before the suite
     del pyauto_suite
     sys.exit(not result.wasSuccessful())
 
 
 if __name__ == '__main__':
   Main()