Enable crash reporting by default with PyAuto on Mac/Linux

Enable crash reporting by default with PyAuto on Mac/Linux

It's already enabled on windows by default. This of course applies only to the branded builds.

Also, make the path to imported pyauto binaries prettier by applying os.path.normpath

Change to chrome_switches.cc is to put a comment at the place where it belongs

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53911

[John Grabowski, 2010-07-27 23:35:30]

http://codereview.chromium.org/2873073/diff/1/3
File chrome/test/pyautolib/pyauto.py (right):

http://codereview.chromium.org/2873073/diff/1/3#newcode1340
chrome/test/pyautolib/pyauto.py:1340: # Enable crash reporter by default on
posix. It's already enabled on win.
If already enabled by default on windows (in the binary itself?), why not enable
it by default on Mac/Linux in the binary itself?

If enabled by cmd line args, why not put this one where that is?

[Nirnimesh, 2010-07-28 01:14:03]

http://codereview.chromium.org/2873073/diff/1/3
File chrome/test/pyautolib/pyauto.py (right):

http://codereview.chromium.org/2873073/diff/1/3#newcode1340
chrome/test/pyautolib/pyauto.py:1340: # Enable crash reporter by default on
posix. It's already enabled on win.
On 2010/07/27 23:35:30, John Grabowski wrote:
> If already enabled by default on windows (in the binary itself?), why not
enable
> it by default on Mac/Linux in the binary itself?
> 
> If enabled by cmd line args, why not put this one where that is?
> 

The win flow is somewhat different, esp after the new first run ui changes.
The choice to enable/disable crash reporting (and user stats) is made at the
installer level, at the time of downloading the installer.

For PyAuto we override the first run UI, which in the old case meant that this
option is disabled by default, but in the new case means that it's enabled by
default. The new first run flow is not available on mac/linux yet.

[John Grabowski, 2010-07-28 01:14:54]

LGTM if explanation moved to comments in code