Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2873068: use_system_ffmpeg broken in gentoo. (Closed)

Created:
10 years, 5 months ago by jiesun
Modified:
9 years, 7 months ago
Reviewers:
Alpha Left Google
Visibility:
Public.

Description

use_system_ffmpeg broken on gentoo side. because if use "system" ffmpeg, AVFrame has no member named "owner". we need use #ifdef to use the single codec context, if system ffmpeg is used. but what if "system" is ffmpeg-mt? Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53695

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M media/media.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jiesun
please have a look.
10 years, 5 months ago (2010-07-26 21:27:23 UTC) #1
Alpha Left Google
ideally you can build those files and enable those features only if use_system_ffmpeg is not ...
10 years, 5 months ago (2010-07-26 21:32:02 UTC) #2
Alpha Left Google
10 years, 5 months ago (2010-07-26 21:34:31 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698