Mark PauseWhenNotConnected as flaky as it keeps timing out,...

Mark PauseWhenNotConnected as flaky as it keeps timing out,
and ServerDeletingFolderWeHaveAnOpenEntryIn is failing 100% of the time.

BUG=39070, 46621
TEST=Syncer unittest, SyncerThreadTest
TBR=skrul

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51505

[Paweł Hajdan Jr., 2010-07-02 06:35:42]

Drive-by.

Timing out = DISABLED, not FLAKY.
Failing 100% = FAILS, not DISABLED.

Sorry that we have so many prefixes. The plan is to reduce it when our test
suite gets better.

[tim (not reviewing), 2010-07-02 06:44:23]

What determines what turns the bots orange / what output shows up in the
waterfall? I see this test (currently marked FAILS) on every commit and
every try job I run and it turns orange. Is that expected? I thought it was
wrongly annotated because I don't see this with other tests...

On Thu, Jul 1, 2010 at 11:35 PM, <phajdan.jr@chromium.org> wrote:

> Drive-by.
>
> Timing out = DISABLED, not FLAKY.
> Failing 100% = FAILS, not DISABLED.
>
> Sorry that we have so many prefixes. The plan is to reduce it when our test
> suite gets better.
>
>
> http://codereview.chromium.org/2873039/show
>

[Paweł Hajdan Jr., 2010-07-02 07:22:00]

Yes, FAILS turns the bot orange and not red.

On Fri, Jul 2, 2010 at 08:43, Tim Steele <tim@chromium.org> wrote:

> What determines what turns the bots orange / what output shows up in the
> waterfall? I see this test (currently marked FAILS) on every commit and
> every try job I run and it turns orange. Is that expected? I thought it was
> wrongly annotated because I don't see this with other tests...
>
> On Thu, Jul 1, 2010 at 11:35 PM, <phajdan.jr@chromium.org> wrote:
>
>> Drive-by.
>>
>> Timing out = DISABLED, not FLAKY.
>> Failing 100% = FAILS, not DISABLED.
>>
>> Sorry that we have so many prefixes. The plan is to reduce it when our
>> test
>> suite gets better.
>>
>>
>> http://codereview.chromium.org/2873039/show
>>
>
>

[skrul, 2010-07-07 16:36:24]

LGTM

[tim (not reviewing), 2010-07-07 17:03:27]

So turns out I was misinterpreting DISABLED and FLAKY, I'll whip up a patch
to make it as Pawel suggests~

On Wed, Jul 7, 2010 at 9:36 AM, <skrul@chromium.org> wrote:

> LGTM
>
>
> http://codereview.chromium.org/2873039/show
>