Issue 2873001: ARM: Special case for modulus of two smis in the generic binary opration stub...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2873001: ARM: Special case for modulus of two smis in the generic binary opration stub... (Closed)

Created:
10 years, 6 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ARM: Special case for modulus of two smis in the generic binary opration stub When lhs and rhs are positive smis and rhs is a power of two perform modulus by masking. Committed: http://code.google.com/p/v8/source/detail?r=4884

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -0 lines)			Patch
	M	src/arm/codegen-arm.cc	View		1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/2873001/diff/1/2 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/2873001/diff/1/2#newcode8172 src/arm/codegen-arm.cc:8172: // support for modulus checking for smis makes ...

10 years, 6 months ago (2010-06-16 15:20:27 UTC) #2

Søren Thygesen Gjesse

10 years, 6 months ago (2010-06-16 20:02:41 UTC) #3

http://codereview.chromium.org/2873001/diff/1/2
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/2873001/diff/1/2#newcode8172
src/arm/codegen-arm.cc:8172: // support for modulus checking for smis makes
sense.
On 2010/06/16 15:20:27, Erik Corry wrote:
> 'even though the default is not to do it' doesn't make sense to me here.

Well I was trying to explain

  ASSERT(!ShouldGenerateSmiCode());

but failed. Rephrased the comment.

Expand Messages | Collapse Messages