Issue 2872014: Change LOG(DFATAL) to avoid dialog in production build...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2872014: Change LOG(DFATAL) to avoid dialog in production build... (Closed)

Created:
10 years, 6 months ago by jar (doing other things)

Modified:
9 years, 7 months ago

Reviewers:
brettw, willchan no longer on Chromium

CC:
chromium-reviews, brettw-cc_chromium.org, Lei Zhang, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Change LOG(DFATAL) to avoid dialog in production build Old semantics: In DEBUG mode: no change: Fatal CHECK error and dialog. In Release mode: Dialog for user, but allow user to continue. New semantics: In Release mode: LOG(ERROR), but don't bother the user. r=brettw,willchan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50679

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	base/logging.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages