Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2871033: Switch to using .vbprivk for signing everything now. (Closed)

Created:
10 years, 5 months ago by Bill Richardson
Modified:
9 years, 6 months ago
Reviewers:
Randall Spangler
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Base URL:
ssh://git@chromiumos-git//vboot_reference.git
Visibility:
Public.

Description

Switch to using .vbprivk for signing everything now. This makes it much simpler to keep track of what we're doing. vbutil_key can now wrap both .keyb and .pem keys. It figures out which is which by trying both and just using the one that works. vbutil_keyblock and vbutil_kernel now use .vbprivk files for signing. replace debug() with VBDEBUG(()) in host-side sources, too. rename PrivateKeyRead to PrivateKeyReadPem Add real PrivateKeyRead and PrivateKeyWrite for .vbprivk files.

Patch Set 1 #

Patch Set 2 : Okay, now tests pass again. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+288 lines, -174 lines) Patch
M firmware/version.c View 1 chunk +1 line, -1 line 0 comments Download
M host/include/host_key.h View 1 chunk +10 lines, -0 lines 0 comments Download
M host/lib/file_keys.c View 4 chunks +6 lines, -6 lines 0 comments Download
M host/lib/host_key.c View 6 chunks +89 lines, -11 lines 0 comments Download
M host/lib/host_keyblock.c View 2 chunks +3 lines, -3 lines 0 comments Download
M host/lib/host_misc.c View 3 chunks +4 lines, -4 lines 0 comments Download
M host/lib/host_signature.c View 1 chunk +1 line, -1 line 0 comments Download
M host/lib/signature_digest.c View 2 chunks +5 lines, -5 lines 0 comments Download
M tests/big_firmware_tests.c View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/big_kernel_tests.c View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/firmware_verify_benchmark.c View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/kernel_rollback_tests.c View 4 chunks +7 lines, -7 lines 0 comments Download
M tests/kernel_verify_benchmark.c View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/rollback_index_mock.c View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/rsa_verify_benchmark.c View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/run_vbutil_tests.sh View 3 chunks +18 lines, -8 lines 0 comments Download
M utility/dump_kernel_config.c View 1 chunk +1 line, -1 line 0 comments Download
M utility/vbutil_kernel.c View 1 chunk +1 line, -1 line 0 comments Download
M utility/vbutil_key.c View 6 chunks +91 lines, -61 lines 2 comments Download
M utility/vbutil_keyblock.c View 7 chunks +31 lines, -45 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bill Richardson
10 years, 5 months ago (2010-07-01 05:42:43 UTC) #1
Bill Richardson
Whups! Hang on - Need to fix some tests...
10 years, 5 months ago (2010-07-01 05:52:20 UTC) #2
Bill Richardson
10 years, 5 months ago (2010-07-01 06:10:41 UTC) #3
gauravsh
+1 haven't looked at the CL but it would be super cool if vbutil_* took ...
10 years, 5 months ago (2010-07-01 06:37:08 UTC) #4
Randall Spangler
10 years, 5 months ago (2010-07-01 16:10:01 UTC) #5 
LGTM with a few minor comment nits

http://codereview.chromium.org/2871033/diff/4001/5019
File utility/vbutil_key.c (right):

http://codereview.chromium.org/2871033/diff/4001/5019#newcode71
utility/vbutil_key.c:71: /* Pack a .keyb file into a .vbpubk */
or a .pem into a .vbprivk

http://codereview.chromium.org/2871033/diff/4001/5019#newcode105
utility/vbutil_key.c:105: /* Unpack a .vbpubk */
or .vbprivk

Powered by Google App Engine
This is Rietveld 408576698