Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2871026: chromeos: Remove Backspace accelerator. (Closed)

Created:
10 years, 6 months ago by Daniel Erat
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org, alcor
Visibility:
Public.

Description

chromeos: Remove Backspace accelerator. The people with whom I spoke (ben, glen, alcor) think that we should expose a better method for going back in the browser history and are okay with removing this for now. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50909

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/views/accelerator_table_gtk.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Daniel Erat
10 years, 6 months ago (2010-06-24 22:16:29 UTC) #1
DaveMoore
LGTM...I love it.
10 years, 6 months ago (2010-06-25 01:06:43 UTC) #2
Aaron Boodman
boo, hiss
10 years, 6 months ago (2010-06-26 00:00:43 UTC) #3
Glen Murphy
As a backspace lover, I also don't like this change, but enough people have asked ...
10 years, 6 months ago (2010-06-26 00:03:02 UTC) #4
Peter Kasting
Filed http://code.google.com/p/chromium-os/issues/detail?id=4348 to revert. You CANNOT remove this accelerator. Please feel free to direct people ...
10 years, 6 months ago (2010-06-26 00:39:15 UTC) #5
Peter Kasting
10 years, 6 months ago (2010-06-26 00:43:31 UTC) #6
On 2010/06/26 00:39:15, Peter Kasting wrote:
> Filed http://code.google.com/p/chromium-os/issues/detail?id=4348 to revert.

Patch at http://codereview.chromium.org/2863027 .

Powered by Google App Engine
This is Rietveld 408576698