chrome/renderer/render_view.cc - Issue 2871023: Revert 50726 "DevTools: Migrate to new WebView initialization (pass devtools client directly)."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/render_view.cc

Issue 2871023: Revert 50726 "DevTools: Migrate to new WebView initialization (pass devtools client directly)." (Closed) Base URL: git://codf21.jail.google.com/chromium.git

Patch Set: Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/render_view.cc

diff --git a/chrome/renderer/render_view.cc b/chrome/renderer/render_view.cc

index 312161b346f515eab0cb6d7a488308e0f68806a5..6b95e29e4e6f2364c85e1fdf2c298aa04829518f 100644

--- a/chrome/renderer/render_view.cc

+++ b/chrome/renderer/render_view.cc

@@ -561,12 +561,14 @@ void RenderView::Init(gfx::NativeViewId parent_hwnd,

devtools_agent_.reset(new DevToolsAgent(routing_id, this));

- webwidget_ = WebView::create(this, devtools_agent_.get());

+ webwidget_ = WebView::create(this);

Singleton<ViewMap>::get()->insert(std::make_pair(webview(), this));

webkit_preferences_.Apply(webview());

webview()->initializeMainFrame(this);

if (!frame_name.empty())

webview()->mainFrame()->setName(frame_name);

+ webview()->setDevToolsAgent(

+ WebDevToolsAgent::create(webview(), devtools_agent_.get()));

OnSetRendererPrefs(renderer_prefs);

« no previous file with comments | « chrome/renderer/print_web_view_helper.cc ('k') | webkit/tools/test_shell/test_shell.h » ('j') | no next file with comments »