Issue 2870062: DevTools: implement basic handshake for remote debugging.

Issue 2870062: DevTools: implement basic handshake for remote debugging. (Closed)

Created:
10 years, 5 months ago by pfeldman

Modified:
9 years, 7 months ago

Reviewers:
yurys

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

DevTools: implement basic handshake for remote debugging. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53624

Patch Set 1 #

Patch Set 2 : utf16 conversion #

Total comments: 4

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+322 lines, -99 lines)			Patch
M	chrome/browser/debugger/devtools_http_protocol_handler.h	View		2 chunks	+32 lines, -11 lines	0 comments	Download
M	chrome/browser/debugger/devtools_http_protocol_handler.cc	View	1	9 chunks	+231 lines, -61 lines	4 comments	Download
M	net/server/http_listen_socket.h	View		3 chunks	+11 lines, -5 lines	0 comments	Download
M	net/server/http_listen_socket.cc	View		8 chunks	+47 lines, -21 lines	0 comments	Download
M	net/server/http_server_request_info.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yurys

LGTM, I don't like those IO and UI suffixes in DevToolsHttpProtocolHandler method names, don't know ...

10 years, 5 months ago (2010-07-22 15:12:42 UTC) #2

pfeldman

10 years, 5 months ago (2010-07-26 12:10:57 UTC) #3

http://codereview.chromium.org/2870062/diff/3001/4001
File chrome/browser/debugger/devtools_http_protocol_handler.cc (right):

http://codereview.chromium.org/2870062/diff/3001/4001#newcode190
chrome/browser/debugger/devtools_http_protocol_handler.cc:190: "<a
href='devtools.html?page=%d'>%s (%s)</a><br>",
On 2010/07/22 15:12:42, Yury Semikhatsky wrote:
> could you send raw data and format them on the client side?

So far I am using this handler for local testing. There will be a JSON-based
protocol instead.

http://codereview.chromium.org/2870062/diff/3001/4001#newcode421
chrome/browser/debugger/devtools_http_protocol_handler.cc:421: if
(controller.session_id().id() == session_id)
On 2010/07/22 15:12:42, Yury Semikhatsky wrote:
> the session id will change on navigation, won't it? while we want to continue
> inspecting the tab

These are persistent!

Expand Messages | Collapse Messages