add cros_deps_diff tool that creates dependency graph diffs

add cros_deps_diff tool that creates dependency graph diffs

This is useful to understand why packages may be different between say, x86 and arm.
Use cros_extract_deps to extract the dependency graph for each, then:
cros_deps_diff -o path/to/output x86-generic.deps arm-generic.deps

[piman, 2010-07-07 21:08:52]

On Wed, Jun 30, 2010 at 8:49 PM, <piman@chromium.org> wrote:

> Reviewers: sosa,
>
> Description:
> add cros_deps_diff tool that creates dependency graph diffs
>
> This is useful to understand why packages may be different between say, x86
> and
> arm.
> Use cros_extract_deps to extract the dependency graph for each, then:
> cros_deps_diff -o path/to/output x86-generic.deps arm-generic.deps
>
> Please review this at http://codereview.chromium.org/2870042/show
>
> SVN Base: ssh://git@chromiumos-git//crosutils.git
>
> Affected files:
>  A cros_deps_diff
>
>
>
Ping ? No urgency, but I just want to check it didn't get lost or something.

Antoine

[sosa, 2010-07-08 18:50:01]

http://codereview.chromium.org/2870042/diff/1/2
File cros_deps_diff (right):

http://codereview.chromium.org/2870042/diff/1/2#newcode63
cros_deps_diff:63: entry = version_map.setdefault(pkg, {})
I'm confused as to what this map is.  Why is the map mapping to a map that takes
a number and maps that to a name?  Can you document this some more?

http://codereview.chromium.org/2870042/diff/1/2#newcode79
cros_deps_diff:79: if value[i] != full_name and full_name:
Switch the ordering of these two.

http://codereview.chromium.org/2870042/diff/1/2#newcode162
cros_deps_diff:162: filename = os.path.join(options.output_dir, pkg.replace('/',
'_')) + '.' + options.format
80 char

http://codereview.chromium.org/2870042/diff/1/2#newcode162
cros_deps_diff:162: filename = os.path.join(options.output_dir, pkg.replace('/',
'_')) + '.' + options.format
Why the flat file format?

[piman, 2010-07-08 20:44:08]

http://codereview.chromium.org/2870042/diff/1/2
File cros_deps_diff (right):

http://codereview.chromium.org/2870042/diff/1/2#newcode63
cros_deps_diff:63: entry = version_map.setdefault(pkg, {})
On 2010/07/08 18:50:01, sosa wrote:
> I'm confused as to what this map is.  Why is the map mapping to a map that
takes
> a number and maps that to a name?  Can you document this some more?
> 
> 

Done.

http://codereview.chromium.org/2870042/diff/1/2#newcode79
cros_deps_diff:79: if value[i] != full_name and full_name:
On 2010/07/08 18:50:01, sosa wrote:
> Switch the ordering of these two.

The ordering actually mattered, but your comment suggested that the code was
unclear. I rewrote it in a way that should be more explicit.

http://codereview.chromium.org/2870042/diff/1/2#newcode162
cros_deps_diff:162: filename = os.path.join(options.output_dir, pkg.replace('/',
'_')) + '.' + options.format
On 2010/07/08 18:50:01, sosa wrote:
> 80 char

Done.

http://codereview.chromium.org/2870042/diff/1/2#newcode162
cros_deps_diff:162: filename = os.path.join(options.output_dir, pkg.replace('/',
'_')) + '.' + options.format
On 2010/07/08 18:50:01, sosa wrote:
> Why the flat file format?

I found it more convenient and easier to generate, but thinking about it, the
tree version works too, so I did that.

[sosa, 2010-07-08 21:08:37]

lgtm!