Issue 287004: Remove dependency on V8_TARGET_ARCH in v8.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 287004: Remove dependency on V8_TARGET_ARCH in v8.h (Closed)

Created:
11 years, 2 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
plesner, Christian Plesner Hansen

CC:
v8-dev

Visibility:
Public.

Description

Remove dependency on V8_TARGET_ARCH in v8.h

Patch Set 1 #

Total comments: 2

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -23 lines)			Patch
	M	include/v8.h	View		2 chunks	+37 lines, -23 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

Lgtm http://codereview.chromium.org/287004/diff/1/2 File include/v8.h (right): http://codereview.chromium.org/287004/diff/1/2#newcode2722 Line 2722: static const int kSmiTag = 0; Some ...

11 years, 2 months ago (2009-10-16 09:39:10 UTC) #2

Lasse Reichstein

11 years, 2 months ago (2009-10-16 10:19:11 UTC) #3

http://codereview.chromium.org/287004/diff/1/2
File include/v8.h (right):

http://codereview.chromium.org/287004/diff/1/2#newcode2722
Line 2722: static const int kSmiTag = 0;
Done. This required moving the templates below the declaration of kSmiTagSize to
enable the SmiToInt function to reference the value.

Expand Messages | Collapse Messages