Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2870033: Grd strings for password changed dialog. (Closed)

Created:
10 years, 5 months ago by Nikita (slow)
Modified:
9 years, 7 months ago
Reviewers:
whywhat
CC:
chromium-reviews
Base URL:
git://codf21.jail/chromium.git
Visibility:
Public.

Description

Grd strings for password changed dialog. BUG= http://crosbug.com/323 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51126

Patch Set 1 #

Patch Set 2 : remove duplicate string #

Total comments: 1

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nikita (slow)
10 years, 5 months ago (2010-06-29 14:44:27 UTC) #1
whywhat
10 years, 5 months ago (2010-06-29 15:07:25 UTC) #2
LGTM

http://codereview.chromium.org/2870033/diff/2001/3001
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/2870033/diff/2001/3001#newcode7606
chrome/app/generated_resources.grd:7606: <message
name="IDS_LOGIN_PREVIOUS_PASSWORD">
Add description here as well?

Powered by Google App Engine
This is Rietveld 408576698