Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2319)

Unified Diff: chrome/common/extensions/url_pattern.h

Issue 2870027: Fix a memory leak in ExtensionExtentUnittest by fixing a bad (Closed) Base URL: git://codf21.jail/chromium.git
Patch Set: remove unneeded header from url_pattern.h Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension_extent_unittest.cc ('k') | chrome/common/extensions/url_pattern.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/url_pattern.h
diff --git a/chrome/common/extensions/url_pattern.h b/chrome/common/extensions/url_pattern.h
index e25faafe210c9f5f1deda8b9c45793f361f7733b..30f2c0f885ad3347b9d08bef859afc18c9a2f026 100644
--- a/chrome/common/extensions/url_pattern.h
+++ b/chrome/common/extensions/url_pattern.h
@@ -73,10 +73,12 @@ class URLPattern {
// otherwise.
static bool IsValidScheme(const std::string& scheme);
- // Convenience to create a pattern from a string.
- static URLPattern* CreateFromString(const std::string& pattern);
+ URLPattern();
- URLPattern() : match_subdomains_(false) {}
+ // Convenience to construct a URLPattern from a string. The string is expected
+ // to be a valid pattern. If the string is not known ahead of time, use
+ // Parse() instead, which returns success or failure.
+ explicit URLPattern(const std::string& pattern);
// Initializes this instance by parsing the provided string. On failure, the
// instance will have some intermediate values and is in an invalid state.
« no previous file with comments | « chrome/common/extensions/extension_extent_unittest.cc ('k') | chrome/common/extensions/url_pattern.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698