Issue 2870012: Fix include path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2870012: Fix include path (Closed)

Created:
10 years, 6 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
kmixter1

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git//crash-dumper.git

Visibility:
Public.

Description

Fix include path TEST=Tested with new ebuild.

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	crash_dumper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kmixter1

10 years, 6 months ago (2010-06-18 03:42:46 UTC) #2

LGTM

On Thu, Jun 17, 2010 at 5:10 PM,  <sosa@chromium.org> wrote:
> Reviewers: kmixter1,
>
> Description:
> Fix include path
>
> TEST=Tested with new ebuild.
>
> Please review this at http://codereview.chromium.org/2870012/show
>
> SVN Base: ssh://git@chromiumos-git//crash-dumper.git
>
> Affected files:
>  M crash_dumper.cc
>
>
> Index: crash_dumper.cc
> diff --git a/crash_dumper.cc b/crash_dumper.cc
> index
>
52d18d7425d1d538db30bd3b5f157c6e71f0eb67..b437c54e1310add7d9882b3da83f8374325a3e49
> 100644
> --- a/crash_dumper.cc
> +++ b/crash_dumper.cc
> @@ -16,7 +16,7 @@
>  #include "client/linux/handler/exception_handler.h"
>  #include "common/linux/linux_libc_support.h"
>  #include "common/linux/linux_syscall_support.h"
> -#include "crash/crash_dumper.h"
> +#include "crash-dumper/crash_dumper.h"
>
>  // Define sys_mkdir (sys_open passes mode_t as int, so we do too).
>  LSS_INLINE _syscall2(int, mkdir, const char *, pathname, int, mode);
>
>
>

Expand Messages | Collapse Messages