Wrapper script for remote_access.sh library. Used by Autotest updater.

Wrapper script for remote_access.sh library. Used by Autotest updater.

[Dale Curtis, 2010-06-22 17:30:46]

Simple wrapper script for remote_access.sh library. Needed by the new Autotest
mass updater to verify SSH connections prior to updating.

[sosa, 2010-06-22 17:33:19]

http://codereview.chromium.org/2869015/diff/1/2
File ssh_test.sh (right):

http://codereview.chromium.org/2869015/diff/1/2#newcode30
ssh_test.sh:30: remote_access_init
Don't you still need to run cleanup if it exits cleanly?

[Dale Curtis, 2010-06-22 17:37:53]

http://codereview.chromium.org/2869015/diff/1/2
File ssh_test.sh (right):

http://codereview.chromium.org/2869015/diff/1/2#newcode30
ssh_test.sh:30: remote_access_init
I was under the impression that the "trap cleanup EXIT" would make sure cleanup
is called when the program finishes under any conditions. Checking my /tmp
directory after a full run seems to indicate this is true.

On 2010/06/22 17:33:19, sosa wrote:
> Don't you still need to run cleanup if it exits cleanly?

[sosa, 2010-06-22 17:40:57]

Ah, I wasn't sure.

LGTM

On Tue, Jun 22, 2010 at 10:37 AM,  <dalecurtis@google.com> wrote:
>
> http://codereview.chromium.org/2869015/diff/1/2
> File ssh_test.sh (right):
>
> http://codereview.chromium.org/2869015/diff/1/2#newcode30
> ssh_test.sh:30: remote_access_init
> I was under the impression that the "trap cleanup EXIT" would make sure
> cleanup is called when the program finishes under any conditions.
> Checking my /tmp directory after a full run seems to indicate this is
> true.
>
> On 2010/06/22 17:33:19, sosa wrote:
>>
>> Don't you still need to run cleanup if it exits cleanly?
>
> http://codereview.chromium.org/2869015/show
>

[sosa, 2010-06-22 18:10:34]

If you haven't committed this yet, can you make a comment about other scripts
depending on this one from the testing infrastructure?  That way we don't
accidentally clean this up at some point.

[Dale Curtis, 2010-06-22 18:15:43]

Done.

On 2010/06/22 18:10:34, sosa wrote:
> If you haven't committed this yet, can you make a comment about other scripts
> depending on this one from the testing infrastructure?  That way we don't
> accidentally clean this up at some point.