Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2868094: Fix --onlydeps flag. (Closed)

Created:
10 years, 4 months ago by davidjames
Modified:
9 years, 4 months ago
Reviewers:
Nick Sanders
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
ssh://git@chromiumos-git/crosutils.git
Visibility:
Public.

Description

Fix --onlydeps flag. When --onlydeps is specified, we don't want to merge packages that were specified on the command-line. Previously, it threw an exception in this case because it couldn't find the command-line packages in the list of installed packages. TEST=Run ./parallel_emerge --onlydeps autotest, and make sure it doesn't crash. Run ./parallel_emerge --board=x86-generic -po chromeos power_manager and make sure it does emerge power_manager, and doesn't crash. BUG=none

Patch Set 1 #

Total comments: 1

Patch Set 2 : Follow emerge's behavior more closely #

Patch Set 3 : Add lots of comments for Nick #

Patch Set 4 : s/, This/, this/g #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M parallel_emerge View 1 2 3 1 chunk +22 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
davidjames
10 years, 4 months ago (2010-08-01 08:07:29 UTC) #1
Nick Sanders
lgtm w/ comments http://codereview.chromium.org/2868094/diff/1/2 File parallel_emerge (right): http://codereview.chromium.org/2868094/diff/1/2#newcode665 parallel_emerge:665: if not selective and "--onlydeps" not ...
10 years, 4 months ago (2010-08-04 20:49:06 UTC) #2
Nick Sanders
10 years, 4 months ago (2010-08-04 21:24:21 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698