Issue 2868081: Revert 54168 - Remove PulseAudio 48553 suppression

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2868081: Revert 54168 - Remove PulseAudio 48553 suppression (Closed)

Created:
10 years, 4 months ago by davejcool

Modified:
9 years, 7 months ago

Reviewers:
brettw, scherkus (not reviewing)

CC:
chromium-reviews, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org, Alexander Potapenko

Base URL:
git://codf21.jail.google.com/chromium.git

Visibility:
Public.

Description

Revert 54168 - Remove PulseAudio 48553 suppression. The memory leaks do not happen if connecting to PulseAudio on the calling (UI) thread at browser init time. Since this change is checked in (r53992), this suppression can be removed. BUG=3013042, 48553 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54192

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

davejcool

This puts the suppression back in since PulseAudio is being initialized off the main thread ...

10 years, 4 months ago (2010-07-29 20:54:25 UTC) #1

LGTM

Expand Messages | Collapse Messages