Issue 2868077: Fix Firefox import lock dialog on Windows....

Issue 2868077: Fix Firefox import lock dialog on Windows.... (Closed)

Created:
10 years, 4 months ago by Miranda Callahan

Modified:
9 years, 7 months ago

Reviewers:
James Hawkins, jeremy

CC:
chromium-reviews, kuchhal, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix Firefox import lock dialog on Windows. BUG=50577 TEST= run chrome first_run with import while Firefox is default browser and open. Dialog should pop up telling user to close FF. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54920

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 4

Patch Set 4 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -22 lines)			Patch
M	chrome/browser/first_run/first_run.h	View	3	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/first_run/first_run_win.cc	View	3	7 chunks	+21 lines, -14 lines	0 comments	Download
M	chrome/browser/importer/importer.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/importer_lock_view.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/importing_progress_view.cc	View	3	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jeremy

LGTM http://codereview.chromium.org/2868077/diff/9001/10002 File chrome/browser/first_run/first_run_win.cc (right): http://codereview.chromium.org/2868077/diff/9001/10002#newcode401 chrome/browser/first_run/first_run_win.cc:401: LOG(ERROR) << "skipping first run ui"; Remove debug ...

10 years, 4 months ago (2010-08-03 23:13:50 UTC) #2

Miranda Callahan

10 years, 4 months ago (2010-08-04 17:02:38 UTC) #4

http://codereview.chromium.org/2868077/diff/9001/10002
File chrome/browser/first_run/first_run_win.cc (right):

http://codereview.chromium.org/2868077/diff/9001/10002#newcode401
chrome/browser/first_run/first_run_win.cc:401: LOG(ERROR) << "skipping first run
ui";
On 2010/08/03 23:13:50, jeremy wrote:
> Remove debug code.

Done.

http://codereview.chromium.org/2868077/diff/9001/10002#newcode713
chrome/browser/first_run/first_run_win.cc:713: skip_first_run_ui ? 1 : 0,
parent_window));
On 2010/08/03 23:13:50, jeremy wrote:
> skip_first_run_ui ? true : false

Hmm, I think I need to explicitly convert bool to int here, otherwise I could
just say "skip_first_run_ui"?  This is for the hack on Windows import where
import is just a browser process with some extra switches encoded to pass
information in.

Expand Messages | Collapse Messages