Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2868076: [Mac] Don't offer profiles for billing addresses that have no address data.... (Closed)

Created:
10 years, 4 months ago by Avi (use Gerrit)
Modified:
9 years, 7 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

[Mac] Don't offer profiles for billing addresses that have no address data. BUG=http://crbug.com/50081 TEST=as in bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54004

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/browser/autofill/autofill_dialog_controller_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autofill/autofill_dialog_controller_mac.mm View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Avi (use Gerrit)
This is what you had in mind? If so I'll do the other platforms too.
10 years, 4 months ago (2010-07-28 18:56:10 UTC) #1
James Hawkins
On 2010/07/28 18:56:10, Avi wrote: > This is what you had in mind? If so ...
10 years, 4 months ago (2010-07-28 18:57:37 UTC) #2
James Hawkins
On 2010/07/28 18:57:37, James Hawkins wrote: > On 2010/07/28 18:56:10, Avi wrote: > > This ...
10 years, 4 months ago (2010-07-28 18:57:50 UTC) #3
James Hawkins
LGTM with comment. http://codereview.chromium.org/2868076/diff/1/3 File chrome/browser/autofill/autofill_dialog_controller_mac.mm (right): http://codereview.chromium.org/2868076/diff/1/3#newcode594 chrome/browser/autofill/autofill_dialog_controller_mac.mm:594: FieldTypeSet fields; Can you add a ...
10 years, 4 months ago (2010-07-28 18:58:35 UTC) #4
Avi (use Gerrit)
> Can you add a comment to clarify why we're making this check? Done; re-upped.
10 years, 4 months ago (2010-07-28 19:06:34 UTC) #5
James Hawkins
10 years, 4 months ago (2010-07-28 19:07:40 UTC) #6
SLGTM, thanks!

Powered by Google App Engine
This is Rietveld 408576698