Issue 2868075: Chrome OS: Prevent overlapping of title and "x" button for devtools window...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2868075: Chrome OS: Prevent overlapping of title and "x" button for devtools window... (Closed)

Created:
10 years, 5 months ago by Dmitry Polukhin

Modified:
9 years, 7 months ago

Reviewers:
whywhat, sky

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Chrome OS: Prevent overlapping of title and "x" button for devtools window BUG=46408 TEST=Title for detached devtools window doesn't overlap with "x" button for long URLs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54104

Patch Set 1 #

Total comments: 4

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -15 lines)			Patch
	M	chrome/browser/views/frame/opaque_browser_frame_view.cc	View		1 chunk	+19 lines, -15 lines	4 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

whywhat

LGTM http://codereview.chromium.org/2868075/diff/1/2 File chrome/browser/views/frame/opaque_browser_frame_view.cc (right): http://codereview.chromium.org/2868075/diff/1/2#newcode960 chrome/browser/views/frame/opaque_browser_frame_view.cc:960: if (is_maximized) { Do we ever have is_maximized ...

10 years, 4 months ago (2010-07-29 06:13:44 UTC) #3

Dmitry Polukhin

10 years, 4 months ago (2010-07-29 06:28:24 UTC) #4

http://codereview.chromium.org/2868075/diff/1/2
File chrome/browser/views/frame/opaque_browser_frame_view.cc (right):

http://codereview.chromium.org/2868075/diff/1/2#newcode960
chrome/browser/views/frame/opaque_browser_frame_view.cc:960: if (is_maximized) {
On 2010/07/29 06:13:44, whywhat wrote:
> Do we ever have is_maximized set to false in Chrome OS?

It looks like no but I can't be 100% sure.

http://codereview.chromium.org/2868075/diff/1/2#newcode981
chrome/browser/views/frame/opaque_browser_frame_view.cc:981:
close_button_->SetVisible(true);
On 2010/07/29 06:13:44, whywhat wrote:
> Shoudn't we set the rest buttons visible here too?

No, because visibility for all other buttons will be reset in code below.

Expand Messages | Collapse Messages