Issue 2868071: Fix for Issue 50340: @page rules inside @media print rules are not properly...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2868071: Fix for Issue 50340: @page rules inside @media print rules are not properly... (Closed)

Created:
10 years, 5 months ago by Yuzo

Modified:
9 years, 7 months ago

Reviewers:
hamaji

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Fix for Issue 50340: @page rules inside @media print rules are not properly handled The cause of the bug is that the document is not in printing mode when the page size is checked. BUG=50340 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53907

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/renderer/print_web_view_helper.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yuzo

Thank you for your review. I think no change is needed for linux. For linux, ...

10 years, 4 months ago (2010-07-28 03:08:45 UTC) #3

Yuzo

10 years, 4 months ago (2010-07-28 21:24:44 UTC) #4

I was wrong :(
Change was needed also for linux. Uploaded a patch to:
http://codereview.chromium.org/3047018/show

On 2010/07/28 03:08:45, Yuzo wrote:
> Thank you for your review.
> 
> I think no change is needed for linux.
> 
> For linux, PrintWebViewHelper::GetPageSizeAndMarginsInPoints is called only
from
> PrintWebViewHelper::Print and PrintWebViewHelper::PrintPage, and it works fine
> in
> that case (for Mac, at least).
> 
> I'll check with linux binary when it's built.
> 
> On 2010/07/27 10:21:39, hamaji wrote:
> > LGTM. Do we need a similar change for linux, too?

Expand Messages | Collapse Messages