Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: chrome/browser/resources/options/chromeos_accounts_options.js

Issue 2868067: Implement new mock for user options page per chromium-os:5028 (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: per arv's comments #2 Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/chromeos_accounts_options.js
diff --git a/chrome/browser/resources/options/chromeos_accounts_options.js b/chrome/browser/resources/options/chromeos_accounts_options.js
index 83396690e1671ce577f2bc9e12ca5c2e027feb94..b6a4c29dc4e83ffc4aa648b644a539541b4b78c5 100644
--- a/chrome/browser/resources/options/chromeos_accounts_options.js
+++ b/chrome/browser/resources/options/chromeos_accounts_options.js
@@ -33,32 +33,35 @@ AccountsOptions.prototype = {
OptionsPage.prototype.initializePage.call(this);
// Set up accounts page.
- $('addUserButton').onclick = function(e) {
- OptionsPage.showOverlay('addUserOverlay');
- };
- $('removeUserButton').onclick = function(e) {
- $('userList').removeSelectedUser();
- };
-
options.accounts.UserList.decorate($('userList'));
- this.addEventListener('visibleChange',
- cr.bind(this.handleVisibleChange_, this));
+ var userNameEdit = $('userNameEdit');
+ options.accounts.UserNameEdit.decorate(userNameEdit);
+ userNameEdit.addEventListener('add', this.handleAddUser_);
- // Setup add user overlay page.
- OptionsPage.registerOverlay(AddUserOverlay.getInstance());
+ this.addEventListener('visibleChange', this.handleVisibleChange_);
},
userListInitalized_: false,
/**
* Handler for OptionsPage's visible property change event.
+ * @private
* @param {Event} e Property change event.
*/
- handleVisibleChange_ : function(e) {
+ handleVisibleChange_: function(e) {
if (!this.userListInitalized_ && this.visible) {
this.userListInitalized_ = true;
userList.redraw();
}
+ },
+
+ /**
+ * Handler for "add" event fired from userNameEdit.
+ * @private
+ * @param {Event} e Add event fired from userNameEdit.
+ */
+ handleAddUser_: function(e) {
+ $('userList').addUser(e.user);
}
};

Powered by Google App Engine
This is Rietveld 408576698