Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2868062: EncoderZlib/DecoderZlib for chromoting (Closed)

Created:
10 years, 5 months ago by Alpha Left Google
Modified:
9 years, 6 months ago
Reviewers:
dmac
CC:
chromium-reviews, Sergey Ulanov, dmac, awong, garykac, Paweł Hajdan Jr., Alpha Left Google
Visibility:
Public.

Description

EncoderZlib/DecoderZlib for chromoting Encoder and decoder using zlib for chromoting. This implementation has zero copy out of the decoder and encoder. The consequence is that we have to break out the zlib stream into rect boundaries which requires the synchronication flush feature in zlib. This feature will hurt compression ratio but the effect still need to be measured. This patch also provides tests for testing the Encoder and Decoder pair with zlib. TEST=remoting_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53738

Patch Set 1 #

Total comments: 6

Patch Set 2 : use compressorflush instead of int #

Patch Set 3 : from .cc to .c #

Unified diffs Side-by-side diffs Delta from patch set Stats (+550 lines, -18 lines) Patch
M remoting/base/codec_test.cc View 1 9 chunks +41 lines, -2 lines 0 comments Download
M remoting/base/compressor.h View 1 3 chunks +16 lines, -2 lines 0 comments Download
M remoting/base/compressor_zlib.h View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/compressor_zlib.cc View 1 3 chunks +27 lines, -5 lines 0 comments Download
M remoting/base/compressor_zlib_unittest.cc View 3 chunks +9 lines, -3 lines 0 comments Download
A remoting/base/decoder_zlib.h View 1 chunk +63 lines, -0 lines 0 comments Download
A remoting/base/decoder_zlib.cc View 1 chunk +143 lines, -0 lines 0 comments Download
A remoting/base/decoder_zlib_unittest.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M remoting/base/decompressor_zlib_unittest.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M remoting/base/encoder_verbatim.cc View 1 chunk +1 line, -2 lines 0 comments Download
A remoting/base/encoder_zlib.h View 1 chunk +46 lines, -0 lines 0 comments Download
A remoting/base/encoder_zlib.cc View 1 1 chunk +138 lines, -0 lines 0 comments Download
A remoting/base/encoder_zlib_unittest.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M remoting/remoting.gyp View 1 2 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Alpha Left Google
10 years, 5 months ago (2010-07-20 07:30:44 UTC) #1
Alpha Left Google
ping.
10 years, 5 months ago (2010-07-23 00:39:53 UTC) #2
dmac
http://codereview.chromium.org/2868062/diff/1/2 File remoting/base/codec_test.cc (right): http://codereview.chromium.org/2868062/diff/1/2#newcode204 remoting/base/codec_test.cc:204: LOG(INFO) << "Testing Rect " << i; did you ...
10 years, 5 months ago (2010-07-23 05:35:08 UTC) #3
Alpha Left Google
http://codereview.chromium.org/2868062/diff/1/2 File remoting/base/codec_test.cc (right): http://codereview.chromium.org/2868062/diff/1/2#newcode204 remoting/base/codec_test.cc:204: LOG(INFO) << "Testing Rect " << i; I do ...
10 years, 5 months ago (2010-07-26 20:59:54 UTC) #4
dmac
10 years, 5 months ago (2010-07-26 21:48:05 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698