Measure and send update time to UMA.

update_attempter.cc

 // Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "update_engine/update_attempter.h"
 
 // From 'man clock_gettime': feature test macro: _POSIX_C_SOURCE >= 199309L
 #ifndef _POSIX_C_SOURCE
 #define _POSIX_C_SOURCE 199309L
 #endif  // _POSIX_C_SOURCE
 #include <time.h>
 
 #include <tr1/memory>
 #include <string>
 #include <vector>
+
 #include <glib.h>
+
+#include "metrics/metrics_library.h"
 #include "update_engine/dbus_service.h"
 #include "update_engine/download_action.h"
 #include "update_engine/filesystem_copier_action.h"
 #include "update_engine/libcurl_http_fetcher.h"
 #include "update_engine/omaha_request_action.h"
 #include "update_engine/omaha_request_params.h"
 #include "update_engine/omaha_response_handler_action.h"
 #include "update_engine/postinstall_runner_action.h"
 #include "update_engine/set_bootable_flag_action.h"
 
@@ skipping 171 matching lines @@
 
 // Delegate methods:
 void UpdateAttempter::ProcessingDone(const ActionProcessor* processor,
                                      ActionExitCode code) {
   CHECK(response_handler_action_);
   LOG(INFO) << "Processing Done.";
   actions_.clear();
   if (code == kActionCodeSuccess) {
     SetStatusAndNotify(UPDATE_STATUS_UPDATED_NEED_REBOOT);
     utils::WriteFile(kUpdateCompletedMarker, "", 0);
+
+    // Report the time it took to update the system.
+    int64_t update_time = time(NULL) - last_checked_time_;
+    metrics_lib_->SendToUMA("Installer.UpdateTime",

[adlr, 2010/07/20 00:08:57]

s/Installer/UpdateEngine/?

[petkov, 2010/07/20 00:19:44]

The convention we've been trying to follow is to keep the group name the same as
the issue tracker focus area. I believe the focus area for the update engine is
Area-Installer?

We have, however, diverged from that convention on a few occasions. So, if you
believe that the tracker area doesn't make sense in this context, I'll switch.
Please confirm.

+                            static_cast<int>(update_time),  // sample
+                            1,  // min = 1 second
+                            20 * 60,  // max = 20 minutes

[adlr, 2010/07/20 00:08:57]

i could definitely see the long tail of updates taking much longer, esp on a
very slow network. Can we do a log scale, or some other non-uniform scale?

[petkov, 2010/07/20 00:19:44]

The default histogram layout is exponential -- smaller bucket ranges at the
lower end and bigger bucket ranges at the higher end.

+                            50);  // buckets
   } else {
     LOG(INFO) << "Update failed.";
     SetStatusAndNotify(UPDATE_STATUS_IDLE);
   }
 }
 
 void UpdateAttempter::ProcessingStopped(const ActionProcessor* processor) {
   download_progress_ = 0.0;
   SetStatusAndNotify(UPDATE_STATUS_IDLE);
   actions_.clear();
@@ skipping 79 matching lines @@
   update_engine_service_emit_status_update(
       dbus_service_,
       last_checked_time_,
       download_progress_,
       UpdateStatusToString(status_),
       new_version_.c_str(),
       new_size_);
 }
 
 }  // namespace chromeos_update_engine