Issue 2868059: Preparatory work for adding content exceptions from the tab cookie view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2868059: Preparatory work for adding content exceptions from the tab cookie view. (Closed)

Created:
10 years, 5 months ago by Bernhard Bauer

Modified:
9 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Preparatory work for adding content exceptions from the tab cookie view. Factor out HostContentSettingsMap::AddExceptionForURL() and add CookieTreeOriginNode::CreateContentException(). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52888

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -16 lines)			Patch
M	chrome/browser/content_setting_bubble_model.cc	View	1 chunk	+2 lines, -10 lines	0 comments	Download
M	chrome/browser/cookies_tree_model.h	View	1 chunk	+7 lines, -6 lines	0 comments	Download
M	chrome/browser/cookies_tree_model.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/host_content_settings_map.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/host_content_settings_map.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bernhard Bauer

Please review. I'll possibly modify the interface if necessary for the UI code.

10 years, 5 months ago (2010-07-19 09:22:04 UTC) #1

jochen (gone - plz use gerrit)

10 years, 5 months ago (2010-07-19 09:26:11 UTC) #2

On 2010/07/19 09:22:04, Bernhard Bauer wrote:
> Please review. I'll possibly modify the interface if necessary for the UI
code.

lgtm

Expand Messages | Collapse Messages