Issue 2868058: [Mac] Re-enable decoration tooltips in omnibox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2868058: [Mac] Re-enable decoration tooltips in omnibox. (Closed)

Created:
10 years, 5 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

[Mac] Re-enable decoration tooltips in omnibox. AutocompleteTextField clears state, then asks AutocompleteTextFieldCell to regenerate the tooltips. BUG=49321 TEST=tooltips for star, content settings, page actions. TEST= AutocompleteTextFieldCellTest.UpdateToolTips Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52940

Patch Set 1 #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -19 lines)			Patch
M	chrome/browser/cocoa/location_bar/autocomplete_text_field.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/location_bar/autocomplete_text_field.mm	View	2 chunks	+8 lines, -13 lines	0 comments	Download
M	chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm	View	4 chunks	+36 lines, -6 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

rand()%rand() == dhollowa! http://codereview.chromium.org/2868058/diff/1/6 File chrome/browser/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm (left): http://codereview.chromium.org/2868058/diff/1/6#oldcode346 chrome/browser/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm:346: NSImage* image = [NSImage imageNamed:@"NSApplicationIcon"]; I, ...

10 years, 5 months ago (2010-07-17 00:35:10 UTC) #1

dhollowa

10 years, 5 months ago (2010-07-19 15:49:27 UTC) #3

On 2010/07/19 15:47:46, dhollowa wrote:
> LGTM!

Please add AutocompleteTextFieldCellTest.UpdateToolTips to TEST= description. 
Thanks.

Expand Messages | Collapse Messages