Issue 2868054: DevTools: provide SSL networks time as a part of LoadTimingInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2868054: DevTools: provide SSL networks time as a part of LoadTimingInfo. (Closed)

Created:
10 years, 5 months ago by pfeldman

Modified:
9 years, 7 months ago

Reviewers:
not_yurys, tonyg

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

DevTools: provide SSL networks time as a part of LoadTimingInfo. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52831

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -0 lines)			Patch
	M	chrome/browser/net/load_timing_observer.h	View		2 chunks	+13 lines, -0 lines	0 comments	Download
	M	chrome/browser/net/load_timing_observer.cc	View		3 chunks	+49 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tonyg

On 2010/07/16 16:19:32, pfeldman wrote: > Given our offline conversation where you indicated tests would ...

10 years, 5 months ago (2010-07-16 16:26:32 UTC) #2

pfeldman

10 years, 5 months ago (2010-07-16 16:31:37 UTC) #3

On 2010/07/16 16:26:32, tonyg wrote:
> On 2010/07/16 16:19:32, pfeldman wrote:
> > 
> 
> Given our offline conversation where you indicated tests would be in a
> subsequent patch, this LGTM.

Thanks for review. Confirming that I do plan on doing tests. I'd like notions
for the numbers to settle a bit first. It should be fairly easy to do the tests
via stealing PassiveLogCollector's utility methods.

Expand Messages | Collapse Messages