Issue 2868033: [Linux]Fix a potential crash issue in gtk_im_context_wrapper.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2868033: [Linux]Fix a potential crash issue in gtk_im_context_wrapper.cc (Closed)

Created:
10 years, 6 months ago by James Su

Modified:
9 years, 7 months ago

Reviewers:
Yusuke Sato, satorux1

CC:
chromium-reviews, jam+cc_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Fix a potential crash issue. BUG=47376 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50697

Patch Set 1 #

Total comments: 2

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -13 lines)			Patch
	M	chrome/browser/renderer_host/gtk_im_context_wrapper.cc	View		7 chunks	+17 lines, -13 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

satorux1

LGTM http://codereview.chromium.org/2868033/diff/1/2 File chrome/browser/renderer_host/gtk_im_context_wrapper.cc (right): http://codereview.chromium.org/2868033/diff/1/2#newcode211 chrome/browser/renderer_host/gtk_im_context_wrapper.cc:211: if (host_view_->GetRenderWidgetHost()) host_view_ is guaranteed not to be ...

10 years, 6 months ago (2010-06-24 04:19:35 UTC) #1

James Su

10 years, 6 months ago (2010-06-24 04:21:46 UTC) #2

http://codereview.chromium.org/2868033/diff/1/2
File chrome/browser/renderer_host/gtk_im_context_wrapper.cc (right):

http://codereview.chromium.org/2868033/diff/1/2#newcode211
chrome/browser/renderer_host/gtk_im_context_wrapper.cc:211: if
(host_view_->GetRenderWidgetHost())
On 2010/06/24 04:19:36, satorux1 wrote:
> host_view_ is guaranteed not to be NULL, right?
Yes. GtkIMContextWrapper object will be destroyed along with the |host_view_|
object.

Expand Messages | Collapse Messages